Skip to content

feat(rust): sqlparser-rs multi-statement guard (#1884) - #1976

Merged
ZhuchkaTriplesix merged 2 commits into
epic/tauri-migrationfrom
issue/1884-sqlparser-multi-statement
Nov 15, 2026
Merged

ZhuchkaTriplesix merged 2 commits into
epic/tauri-migrationfrom
issue/1884-sqlparser-multi-statement

Conversation

@ZhuchkaTriplesix

Copy link
Copy Markdown
Member

Summary

  • Add sqlparser and a sql_guard module that parses SQL per driver dialect and allows exactly one statement (trailing ; / comments OK; ; inside strings OK).
  • Wire the guard into ConnectionRegistry::execute_query; refusals return typed ConnectionError::SqlGuard (empty_query / single_statement / parse_error).
  • Unit tests for allowed/blocked scripts + registry multi-statement rejection.

Closes #1884

Test plan

  • cargo test --lib (48 passed)
  • cargo clippy --all-targets -- -D warnings
  • CI green on this PR
  • Optional: in-app run SELECT 1; SELECT 2 and confirm typed guard error

Reject empty and multi-statement SQL at db_execute_query with a typed
SqlGuard error so drivers only ever see one statement per call.
@github-actions github-actions Bot added parser Theme parser epic label: parser P1 High priority / Core capability tauri Tauri 2 / apps/tauri migration track rust Rust backend (src-tauri / crates) labels Nov 15, 2026
@github-actions github-actions Bot added this to the Tauri migration milestone Nov 15, 2026
@ZhuchkaTriplesix
ZhuchkaTriplesix merged commit f9a2de1 into epic/tauri-migration Nov 15, 2026
3 checks passed
@ZhuchkaTriplesix
ZhuchkaTriplesix deleted the issue/1884-sqlparser-multi-statement branch November 15, 2026 10:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

P1 High priority / Core capability parser Theme parser epic label: parser rust Rust backend (src-tauri / crates) tauri Tauri 2 / apps/tauri migration track

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant